Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: move tests that pull in server to a different package #49737

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

jordanlewis
Copy link
Member

This adds the tree/eval_test package, which has dependencies on server
and colexec. The tree_test package itself doesn't have to have these
heavy deps anymore, which will speed up debugging cycles.

Release note: None

@jordanlewis jordanlewis requested review from RaduBerinde and a team May 30, 2020 22:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

This adds the tree/eval_test package, which has dependencies on server
and colexec. The tree_test package itself doesn't have to have these
heavy deps anymore, which will speed up debugging cycles.

Release note: None
@jordanlewis
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 5, 2020

Build failed

@jordanlewis
Copy link
Member Author

Flaky test. Filed: #49896

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 5, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Jun 5, 2020

Build succeeded

@craig craig bot merged commit 04445a9 into cockroachdb:master Jun 5, 2020
@jordanlewis jordanlewis deleted the eval_test branch June 11, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants